lkml.org 
[lkml]   [2021]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] mailbox: sprd: correct definition of SPRD_OUTBOX_FIFO_FULL
On Thu, Feb 4, 2021 at 4:18 PM Chunyan Zhang <zhang.lyra@gmail.com> wrote:
>
> From: Magnum Shan <magnum.shan@unisoc.com>
>
> According to the specification, bit[2] represents SPRD_OUTBOX_FIFO_FULL,
> not bit[0], so correct it.
>
> Fixes: ca27fc26cd22 ("mailbox: sprd: Add Spreadtrum mailbox driver")
> Signed-off-by: Magnum Shan <magnum.shan@unisoc.com>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>

LGTM.
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>

> ---
> drivers/mailbox/sprd-mailbox.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mailbox/sprd-mailbox.c b/drivers/mailbox/sprd-mailbox.c
> index f6fab24ae8a9..4c325301a2fe 100644
> --- a/drivers/mailbox/sprd-mailbox.c
> +++ b/drivers/mailbox/sprd-mailbox.c
> @@ -35,7 +35,7 @@
> #define SPRD_MBOX_IRQ_CLR BIT(0)
>
> /* Bit and mask definiation for outbox's SPRD_MBOX_FIFO_STS register */
> -#define SPRD_OUTBOX_FIFO_FULL BIT(0)
> +#define SPRD_OUTBOX_FIFO_FULL BIT(2)
> #define SPRD_OUTBOX_FIFO_WR_SHIFT 16
> #define SPRD_OUTBOX_FIFO_RD_SHIFT 24
> #define SPRD_OUTBOX_FIFO_POS_MASK GENMASK(7, 0)
> --
> 2.25.1
>


--
Baolin Wang

\
 
 \ /
  Last update: 2021-02-04 12:02    [W:0.087 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site