lkml.org 
[lkml]   [2021]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][RESEND] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed
On Wed 2021-02-03 15:47:27, Steven Rostedt wrote:
> On Wed, 3 Feb 2021 12:35:07 -0800
> Kees Cook <keescook@chromium.org> wrote:
>
> > > With a big notice that all pointers of unhashed, I don't think we need to
> > > print it failed when we expect it to fail.
> > >
> > > If anything, skip the test and state:
> > >
> > > test_printf: hash test skipped because "make-printk-non-secret" is on the
> > > command line.
> >
> > Yeah, I'm fine with "fail" or "skip". "pass" is mainly what I don't
> > like. :)
>
> Is there any printing of the tests being done? Looks to me that the tests
> only print something if they fail. Thus "skip" and "pass" are basically the
> same (if "skip" is simply not to do the test).

It prints the total number of tests done. It should not count the
skipped tests.

We actually print a warning when crng is not initialized. In this
case, the test passes because we actually check the value and it
is an expected one.

> I mean, we could simply have:
>
>
> static void __init
> plain(void)
> {
> int err;
>
> + if (debug_never_hash_pointers)
> + return;

I am not 100% sure. But this might work. Just please print a warning
about the tests are skipped.

Best Regards,
Petr

\
 
 \ /
  Last update: 2021-02-04 10:38    [W:0.068 / U:1.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site