lkml.org 
[lkml]   [2021]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next] RISCV: Add some depends for NUMA
From
Date

On 2021/2/4 3:59, Atish Patra wrote:
> On Wed, Feb 3, 2021 at 6:20 AM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>> The numa feature is useless for riscv32 platform(MAXPHYSMEM_1GB if 32bit),
>> and it should depends on SMP feature, this also fix the build error,
>>
>> riscv64-buildroot-linux-gnu-ld: mm/page_alloc.o: in function `.L0 ':
>> page_alloc.c:(.text+0x4808): undefined reference to `node_reclaim_distance'
>>
> Thanks for the fix. The commit text is a bit ambiguous. The
> compilation issue error is due to SMP.
> RV32 dependency is just another fix as NUMA is not very useful for RV32.

Yes, the two depends fix different issue,the lack of SMP leads to the
compilation issue,  another

depend is to remove support on RV32.

Thanks for your review, if necessary, I could resend with changelog
updated.

> Reviewed-by: Atish Patra <atish.patra@wdc.com>

\
 
 \ /
  Last update: 2021-02-04 10:22    [W:0.071 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site