Messages in this thread |  | | Subject | Re: [PATCH net] rxrpc: Fix clearance of Tx/Rx ring when releasing a call | From | patchwork-bot+netdevbpf@kernel ... | Date | Fri, 05 Feb 2021 02:20:06 +0000 |
| |
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Wed, 03 Feb 2021 08:47:56 +0000 you wrote: > At the end of rxrpc_release_call(), rxrpc_cleanup_ring() is called to clear > the Rx/Tx skbuff ring, but this doesn't lock the ring whilst it's accessing > it. Unfortunately, rxrpc_resend() might be trying to retransmit a packet > concurrently with this - and whilst it does lock the ring, this isn't > protection against rxrpc_cleanup_call(). > > Fix this by removing the call to rxrpc_cleanup_ring() from > rxrpc_release_call(). rxrpc_cleanup_ring() will be called again anyway > from rxrpc_cleanup_call(). The earlier call is just an optimisation to > recycle skbuffs more quickly. > > [...]
Here is the summary with links: - [net] rxrpc: Fix clearance of Tx/Rx ring when releasing a call https://git.kernel.org/netdev/net/c/7b5eab57cac4
You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
|  |