lkml.org 
[lkml]   [2021]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mm/hugetlb: use helper function range_in_vma() in page_table_shareable()
From
Date
On 2/4/21 3:29 AM, Miaohe Lin wrote:
> We could use helper function range_in_vma() to check whether the vma is in
> the desired range to simplify the code.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> mm/hugetlb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks,

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>

--
Mike Kravetz

>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index cf82629319ed..442705be052a 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -5237,7 +5237,7 @@ static unsigned long page_table_shareable(struct vm_area_struct *svma,
> */
> if (pmd_index(addr) != pmd_index(saddr) ||
> vm_flags != svm_flags ||
> - sbase < svma->vm_start || svma->vm_end < s_end)
> + !range_in_vma(svma, sbase, s_end))
> return 0;
>
> return saddr;
>

\
 
 \ /
  Last update: 2021-02-04 22:41    [W:0.046 / U:2.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site