lkml.org 
[lkml]   [2021]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed
On Thu, 4 Feb 2021 21:48:35 +0100
Pavel Machek <pavel@ucw.cz> wrote:

> > + pr_warn("** Kernel memory addresses are exposed, which may **\n");
> > + pr_warn("** compromise security on your system. **\n");
>
> This is lies, right? And way too verbose.

Not really. More of an exaggeration than a lie. And the verbosity is to
make sure it's noticed by those that shouldn't have it set. This works well
for keeping trace_printk() out of production kernels. Why do you care
anyway, you are just debugging it, and it shouldn't trigger any bug reports
on testing infrastructure. That's why I like the notice. It gets the job
done of keeping people from using things they shouldn't be using, and
doesn't cause testing failures that a WARN_ON would.

-- Steve

\
 
 \ /
  Last update: 2021-02-04 21:57    [W:0.128 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site