Messages in this thread | | | Subject | Re: [PATCH] KVM: SVM: Use 'unsigned long' for the physical address passed to VMSAVE | From | Paolo Bonzini <> | Date | Wed, 3 Feb 2021 09:03:50 +0100 |
| |
On 02/02/21 23:34, Sean Christopherson wrote: > diff --git a/arch/x86/kvm/svm/svm_ops.h b/arch/x86/kvm/svm/svm_ops.h > index 0c8377aee52c..9f007bc8409a 100644 > --- a/arch/x86/kvm/svm/svm_ops.h > +++ b/arch/x86/kvm/svm/svm_ops.h > @@ -51,7 +51,12 @@ static inline void invlpga(unsigned long addr, u32 asid) > svm_asm2(invlpga, "c"(asid), "a"(addr)); > } > > -static inline void vmsave(hpa_t pa) > +/* > + * Despite being a physical address, the portion of rAX that is consumed by > + * VMSAVE, VMLOAD, etc... is still controlled by the effective address size, > + * hence 'unsigned long' instead of 'hpa_t'. > + */ > +static inline void vmsave(unsigned long pa) > { > svm_asm1(vmsave, "a" (pa), "memory"); > } > -- > 2.30.0.365.g02bc693789-goog >
Squashed, thanks.
Paolo
| |