lkml.org 
[lkml]   [2021]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V2] drivers: net: ethernet: i825xx: Fix couple of spellings and get rid of blank lines too in the file ether1.c
From
Date
On 2/3/21 6:32 PM, Bhaskar Chowdhury wrote:
> On 18:09 Wed 03 Feb 2021, Randy Dunlap wrote:
>> On 2/3/21 5:18 PM, Bhaskar Chowdhury wrote:
>>>
>>> s/initialsation/initialisation/
>>> s/specifiing/specifying/
>>>
>>> Plus get rid of few blank lines.
>>>
>>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>>> ---
>>> Changes from V1:
>>>    Fix typo in the subject line
>>>    Give explanation of all the changes in changelog text
>>>
>>>  drivers/net/ethernet/i825xx/ether1.c | 9 +++------
>>>  1 file changed, 3 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/net/ethernet/i825xx/ether1.c b/drivers/net/ethernet/i825xx/ether1.c
>>> index a0bfb509e002..850ea32091ed 100644
>>> --- a/drivers/net/ethernet/i825xx/ether1.c
>>> +++ b/drivers/net/ethernet/i825xx/ether1.c
>>
>> a. don't delete the blank lines
>> b. the change below is not described and does not change any whitespace AFAICT.
>>   I.e., DDT [don't do that].
>>
> But what do you do when things getting automatically inducted in the
> patch???(You got to believe me)
>
> I haven't had touch that bloody function with my keystroke and it gets it on
> its own! Bemusing!
>
> Those blank lines too inducted from the fresh file(means in pristine form) ,so
> thought pruning would be good..hence the decision to get rid of those.
>
> Wondering what the fuck is going on....

Yeah, it seems like you have had editor-doing-too-much-for-you issues before now...

--
~Randy

\
 
 \ /
  Last update: 2021-02-04 04:36    [W:0.059 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site