Messages in this thread | | | Subject | Re: [PATCH v3 4/5] ACPI: video: Clean up printing messages | From | Hanjun Guo <> | Date | Thu, 4 Feb 2021 09:42:43 +0800 |
| |
On 2021/2/4 2:48, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki<rafael.j.wysocki@intel.com> > > Replace the ACPI_DEBUG_PRINT() instances in acpi_video.c with > acpi_handle_debug() calls and the ACPI_EXCEPTION()/ACPI_ERROR()/ > ACPI_WARNING() instances in there with acpi_handle_info() calls, > which among other things causes the excessive log levels of those > messages to be increased. > > Drop the _COMPONENT and ACPI_MODULE_NAME() definitions that are not > used any more from acpi_video.c, drop the no longer needed > ACPI_VIDEO_COMPONENT definition from the headers and update the > documentation accordingly. > > While at it, add a pr_fmt() definition to acpi_video.c, replace the > direct printk() invocations in there with acpi_handle_info() or > pr_info() (and reduce the excessive log level where applicable) and > drop the PREFIX sybmbol definition which is not necessary any more > from acpi_video.c. > > Also make unrelated janitorial changes to fix up white space and > use ACPI_FAILURE() instead of negating ACPI_SUCCESS(). > > Signed-off-by: Rafael J. Wysocki<rafael.j.wysocki@intel.com>
Reviewed-by: Hanjun Guo <guohanjun@huawei.com>
Thanks Hanjun
| |