lkml.org 
[lkml]   [2021]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v3 4/5] ACPI: video: Clean up printing messages
    From
    Date
    On 2021/2/4 2:48, Rafael J. Wysocki wrote:
    > From: Rafael J. Wysocki<rafael.j.wysocki@intel.com>
    >
    > Replace the ACPI_DEBUG_PRINT() instances in acpi_video.c with
    > acpi_handle_debug() calls and the ACPI_EXCEPTION()/ACPI_ERROR()/
    > ACPI_WARNING() instances in there with acpi_handle_info() calls,
    > which among other things causes the excessive log levels of those
    > messages to be increased.
    >
    > Drop the _COMPONENT and ACPI_MODULE_NAME() definitions that are not
    > used any more from acpi_video.c, drop the no longer needed
    > ACPI_VIDEO_COMPONENT definition from the headers and update the
    > documentation accordingly.
    >
    > While at it, add a pr_fmt() definition to acpi_video.c, replace the
    > direct printk() invocations in there with acpi_handle_info() or
    > pr_info() (and reduce the excessive log level where applicable) and
    > drop the PREFIX sybmbol definition which is not necessary any more
    > from acpi_video.c.
    >
    > Also make unrelated janitorial changes to fix up white space and
    > use ACPI_FAILURE() instead of negating ACPI_SUCCESS().
    >
    > Signed-off-by: Rafael J. Wysocki<rafael.j.wysocki@intel.com>

    Reviewed-by: Hanjun Guo <guohanjun@huawei.com>

    Thanks
    Hanjun

    \
     
     \ /
      Last update: 2021-02-04 02:45    [W:2.533 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site