lkml.org 
[lkml]   [2021]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRE: [PATCH][next] dmaengine: dw-axi-dmac: remove redundant null check on desc
Date
The code looks good to me. I have also verified it on Intel KeemBay platform.

Reviewed-by: Sia Jee Heng <jee.heng.sia@intel.com>
Tested-by: Sia Jee Heng <jee.heng.sia@intel.com>

Thanks
Regards
Jee Heng
> -----Original Message-----
> From: Colin King <colin.king@canonical.com>
> Sent: 03 February 2021 9:47 PM
> To: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>; Vinod Koul
> <vkoul@kernel.org>; Sia, Jee Heng <jee.heng.sia@intel.com>; Andy
> Shevchenko <andriy.shevchenko@linux.intel.com>;
> dmaengine@vger.kernel.org
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH][next] dmaengine: dw-axi-dmac: remove redundant
> null check on desc
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer desc is being null checked twice, the second null check is
> redundant because desc has not been re-assigned between the checks.
> Remove the redundant second null check on desc.
>
> Addresses-Coverity: ("Logically dead code")
> Fixes: ef6fb2d6f1ab ("dmaengine: dw-axi-dmac: simplify descriptor
> management")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> index ac3d81b72a15..d9e4ac3edb4e 100644
> --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> @@ -919,10 +919,6 @@ dma_chan_prep_dma_memcpy(struct
> dma_chan *dchan, dma_addr_t dst_adr,
> num++;
> }
>
> - /* Total len of src/dest sg == 0, so no descriptor were
> allocated */
> - if (unlikely(!desc))
> - return NULL;
> -
> /* Set end-of-link to the last link descriptor of list */
> set_desc_last(&desc->hw_desc[num - 1]);
> /* Managed transfer list */
> --
> 2.29.2

\
 
 \ /
  Last update: 2021-02-04 01:21    [W:4.278 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site