Messages in this thread | | | Subject | Re: [PATCH v4] misc: bcm-vk: only support ttyVK if CONFIG_TTY is set | From | Randy Dunlap <> | Date | Wed, 3 Feb 2021 15:18:15 -0800 |
| |
On 2/3/21 2:38 PM, Scott Branden wrote: > Correct compile issue if CONFIG_TTY is not set by > only adding ttyVK devices if CONFIG_BCM_VK_TTY is set. > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Signed-off-by: Scott Branden <scott.branden@broadcom.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> > --- > Changes since v3: > - Kconfig cleanups below as per Greg's comments > - changed if BCM_VK to depends on BCM_VK > - removed default y in CONFIG_BCM_VK_TTY > - expanded decription of CONFIG_BCM_VK_TTY > Changes since v2: > - add CONFIG_BCM_VK_TTY > - add function and stub for bcm_vk_tty_set_irq_enabled > Changes since v1: > - add function stubs rather than compiling out code > --- > drivers/misc/bcm-vk/Kconfig | 12 +++++++++ > drivers/misc/bcm-vk/Makefile | 4 +-- > drivers/misc/bcm-vk/bcm_vk.h | 42 +++++++++++++++++++++++++++++--- > drivers/misc/bcm-vk/bcm_vk_dev.c | 5 ++-- > drivers/misc/bcm-vk/bcm_vk_tty.c | 6 +++++ > 5 files changed, 61 insertions(+), 8 deletions(-)
-- ~Randy
| |