Messages in this thread | | | Date | Wed, 3 Feb 2021 23:05:29 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] misc: bcm-vk: Fix a couple error codes in probe() |
| |
On Wed, Feb 03, 2021 at 11:15:35AM -0800, Scott Branden wrote: > Thanks Dan, > > On 2021-02-03 6:42 a.m., Dan Carpenter wrote: > > These errors should return negative error codes instead of returning > > success. > Do you have a script running to report such issues or just manually reviewing > to find such paths?
Yeah. This is a new Smatch check. The heuristic is this:
<-- ret is not set within 3 lines of the goto goto label; <-- we hit a goto
return 0; <-- success path right before the cleanup block
label: <-- labels return ret; <-- This return has to sometimes returns negatives
regards, dan carpenter
| |