lkml.org 
[lkml]   [2021]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 1/4] ACPI: processor: Get rid of ACPICA message printing
From
Date
On 2021/2/25 2:06, Rafael J. Wysocki wrote:
> On Tue, Feb 23, 2021 at 3:45 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>>
>> On Tue, Feb 23, 2021 at 12:31 PM Hanjun Guo <guohanjun@huawei.com> wrote:
>>>
>>> On 2021/2/23 2:59, Rafael J. Wysocki wrote:
>>>> Index: linux-pm/drivers/acpi/processor_idle.c
>>>> ===================================================================
>>>> --- linux-pm.orig/drivers/acpi/processor_idle.c
>>>> +++ linux-pm/drivers/acpi/processor_idle.c
>>>
>>> In this file, function acpi_processor_cstate_first_run_checks()
>>> has a wrong pr_notice():
>>>
>>> pr_notice("ACPI: processor limited to max C-state %d\n",
>>> max_cstate);
>>>
>>> Since we have pr_fmt() for this file, "ACPI:" is duplicate,
>>> we'd better cleanup this as below:
>>>
>>> pr_notice("processor limited to max C-state %d\n", max_cstate);
>>
>> Thanks for pointing this out, I'll make this change when applying the patch.
>
> Actually, this issue is not strictly related to the patch here, so I'm
> going to send a separate patch to fix it.

Make sense to me as well.

Thanks
Hanjun

\
 
 \ /
  Last update: 2021-02-25 15:21    [W:0.036 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site