Messages in this thread | | | Subject | Re: [PATCH] init/Kconfig: make COMPILE_TEST depend on HAS_IOMEM | From | "Enrico Weigelt, metux IT consult" <> | Date | Wed, 24 Feb 2021 16:58:22 +0100 |
| |
On 24.02.21 15:08, Masahiro Yamada wrote: > I read the commit log of the following two: > > - bc083a64b6c0 ("init/Kconfig: make COMPILE_TEST depend on !UML") > - 334ef6ed06fa ("init/Kconfig: make COMPILE_TEST depend on !S390") > > Both are talking about HAS_IOMEM dependency missing in many drivers. > > So, 'depends on HAS_IOMEM' seems the direct, sensible solution to me.
I don't like idea of hidden indirect dependencies. If a driver needs iomem, then it should depend on it. Yes, a lot of drivers might need to be fixed, but IMHO we should do that, instead of covering 'em up.
--mtx
-- --- Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren GPG/PGP-Schlüssel zu. --- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@metux.net -- +49-151-27565287
| |