lkml.org 
[lkml]   [2021]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3] x86/fault: Send a SIGBUS to user process always for hwpoison page access.
Date

> On Feb 23, 2021, at 4:44 AM, Aili Yao <yaoaili@kingsoft.com> wrote:
>
> On Fri, 5 Feb 2021 17:01:35 +0800
> Aili Yao <yaoaili@kingsoft.com> wrote:
>
>> When one page is already hwpoisoned by MCE AO action, processes may not
>> be killed, processes mapping this page may make a syscall include this
>> page and result to trigger a VM_FAULT_HWPOISON fault, as it's in kernel
>> mode it may be fixed by fixup_exception, current code will just return
>> error code to user code.
>>
>> This is not sufficient, we should send a SIGBUS to the process and log
>> the info to console, as we can't trust the process will handle the error
>> correctly.
>>
>> Suggested-by: Feng Yang <yangfeng1@kingsoft.com>
>> Signed-off-by: Aili Yao <yaoaili@kingsoft.com>
>> ---
>> arch/x86/mm/fault.c | 62 +++++++++++++++++++++++++++++----------------
>> 1 file changed, 40 insertions(+), 22 deletions(-)
>>
> Hi luto;
> Is there any feedback?

At the very least, this needs a clear explanation of why your proposed behavior is better than the existing behavior.

>
> Thanks
> Aili Yao

\
 
 \ /
  Last update: 2021-02-23 16:35    [W:0.063 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site