lkml.org 
[lkml]   [2021]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH RFC 4/4] perf/core: Add breakpoint information to siginfo on SIGTRAP
On Tue, Feb 23, 2021 at 3:34 PM Marco Elver <elver@google.com> wrote:
>
> Encode information from breakpoint attributes into siginfo_t, which
> helps disambiguate which breakpoint fired.
>
> Note, providing the event fd may be unreliable, since the event may have
> been modified (via PERF_EVENT_IOC_MODIFY_ATTRIBUTES) between the event
> triggering and the signal being delivered to user space.
>
> Signed-off-by: Marco Elver <elver@google.com>
> ---
> kernel/events/core.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 8718763045fd..d7908322d796 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -6296,6 +6296,17 @@ static void perf_sigtrap(struct perf_event *event)
> info.si_signo = SIGTRAP;
> info.si_code = TRAP_PERF;
> info.si_errno = event->attr.type;
> +
> + switch (event->attr.type) {
> + case PERF_TYPE_BREAKPOINT:
> + info.si_addr = (void *)(unsigned long)event->attr.bp_addr;
> + info.si_perf = (event->attr.bp_len << 16) | (u64)event->attr.bp_type;
> + break;
> + default:
> + /* No additional info set. */

Should we prohibit using attr.sigtrap for !PERF_TYPE_BREAKPOINT if we
don't know what info to pass yet?

> + break;
> + }
> +
> force_sig_info(&info);
> }
>
> --
> 2.30.0.617.g56c4b15f3c-goog
>

\
 
 \ /
  Last update: 2021-02-23 16:05    [W:0.056 / U:4.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site