Messages in this thread |  | | Subject | Re: [PATCH] sched/fair: Fix task utilization accountability in cpu_util_next() | From | Dietmar Eggemann <> | Date | Tue, 23 Feb 2021 15:44:41 +0100 |
| |
On 22/02/2021 10:54, vincent.donnefort@arm.com wrote: > From: Vincent Donnefort <vincent.donnefort@arm.com>
[...]
> Also, replace sub_positive with lsub_positive which saves one explicit > load-store.
IMHO, in case you're going to fix this now in compute_energy(), this optimization could still be done. Maybe in an extra patch? cpu_util_without() is using lsub_positive() to remove task util from cpu util as well.
[...]
|  |