lkml.org 
[lkml]   [2021]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tty/serial:Remove superfluous "breaks"
On Tue, Feb 23, 2021 at 04:06:30PM +0800, dingsenjie@163.com wrote:
> From: dingsenjie <dingsenjie@yulong.com>
>
> Remove superfluous "breaks", as there is a "return" before them.
>
> Signed-off-by: dingsenjie <dingsenjie@yulong.com>

You are at least the fourth person who sends this patch[1]. The things I
wrote in reply to the latest submission still applies:

- the Subject is wrong, it should use a prefix similar to "serial: imx:".

- I personally like the breaks for clarity.

- If people agree enough to outvote me, please at least add an empty
line instead of just removing the break to visually separate the
cases.

Thanks
Uwe

[1] https://lore.kernel.org/r/20201026125142.21105-1-zhangqilong3@huawei.com
https://lore.kernel.org/r/20201020130709.28096-1-trix@redhat.com
https://lore.kernel.org/r/20201107140129.kpfhanzjidvdg662@pengutronix.de

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-02-23 15:26    [W:0.033 / U:6.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site