[lkml]   [2021]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] tty/serial:Remove superfluous "breaks"
On Tue, Feb 23, 2021 at 04:06:30PM +0800, wrote:
> From: dingsenjie <>
> Remove superfluous "breaks", as there is a "return" before them.
> Signed-off-by: dingsenjie <>

You are at least the fourth person who sends this patch[1]. The things I
wrote in reply to the latest submission still applies:

- the Subject is wrong, it should use a prefix similar to "serial: imx:".

- I personally like the breaks for clarity.

- If people agree enough to outvote me, please at least add an empty
line instead of just removing the break to visually separate the



Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | |
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2021-02-23 15:26    [W:0.033 / U:6.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site