lkml.org 
[lkml]   [2021]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] irqchip/bcm-6345-l1: fix SMP support
From
Date
Hi Florian,

Yes, you’re right, there seems to be a bug, because cpu_number_map() and cpu_logical_map() are returning the same when BCM6358 starts with CMT 1:
[ 4.662896] bcm6345_l1_irq_handle: smp_id=0 cpu_logical=1 cpu_number=1

Let’s see if I can fix it…

Best regards,
Álvaro.

> El 22 feb 2021, a las 22:00, Florian Fainelli <f.fainelli@gmail.com> escribió:
>
>
>
> On 2/22/2021 12:13 PM, Álvaro Fernández Rojas wrote:
>> Some BCM6358 devices start with Core #1 instead of Core #0.
>> Apart from that, SMP is restricted to 1 CPU since BCM6358 has a shared TLB,
>> which makes it impossible for the current SMP support to start both CPUs.
>>
>> The problem is that smp_processor_id() returns 0 and then cpu_logical_map()
>> converts that to 1, which accesses an uninitialized position of intc->cpus[],
>> resulting in a kernel panic.
>
> Sounds like you nee to correct the way the cpu_logical_map[] is
> populated then?
> --
> Florian

\
 
 \ /
  Last update: 2021-02-23 13:32    [W:0.032 / U:31.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site