Messages in this thread |  | | Date | Tue, 23 Feb 2021 09:45:32 +0000 | From | Will Deacon <> | Subject | Re: [PATCH v2] kexec: move machine_kexec_post_load() to public interface |
| |
On Mon, Feb 22, 2021 at 11:16:38PM -0600, Eric W. Biederman wrote: > Will Deacon <will@kernel.org> writes: > > > On Fri, 19 Feb 2021 14:51:42 -0500, Pavel Tatashin wrote: > >> machine_kexec_post_load() is called after kexec load is finished. It must > >> declared in public header not in kexec_internal.h > >> > >> Fixes the following compiler warning: > >> > >> arch/arm64/kernel/machine_kexec.c:62:5: warning: no previous prototype for > >> function 'machine_kexec_post_load' [-Wmissing-prototypes] > >> int machine_kexec_post_load(struct kimage *kimage) > > > > Applied to arm64 (for-next/fixes), thanks! > > > > [1/1] kexec: move machine_kexec_post_load() to public interface > > https://git.kernel.org/arm64/c/2596b6ae412b > > As you have already applied this it seems a bit late, > but I will mention that change could legitimately have the following > tag. > > Fixes: de68e4daea90 ("kexec: add machine_kexec_post_load()") > > So far arm64 is the only implementation of that hook.
I added 'Fixes: 4c3c31230c91 ("arm64: kexec: move relocation function setup")' when I applied the patch, so at least it's clearly marked as a fix.
Will
|  |