Messages in this thread | | | Date | Tue, 23 Feb 2021 13:25:58 +0800 | From | Gao Xiang <> | Subject | Re: [PATCH v2] erofs: support adjust lz4 history window size |
| |
(cont. the previous reply)
On Tue, Feb 23, 2021 at 01:19:26PM +0800, Gao Xiang wrote:
...
> > + __le16 lz4_max_distance; /* lz4 max distance */
unneeded comment.
> > + __u8 reserved2[42]; > > }; > > > > /* > > diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h > > index 67a7ec945686..7457710a763a 100644 > > --- a/fs/erofs/internal.h > > +++ b/fs/erofs/internal.h > > @@ -70,6 +70,9 @@ struct erofs_sb_info { > > > > /* pseudo inode to manage cached pages */ > > struct inode *managed_cache; > > + > > + /* lz4 max distance pages */ > > + u16 lz4_max_distance_pages;
useless comment as well... maybe we could add some descriptive words, e.g.
/* # of pages needed for EROFS lz4 rolling decompression */
Thanks, Gao Xiang
| |