lkml.org 
[lkml]   [2021]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 3/3] mm: Fix missing mem cgroup soft limit tree updates
From
Date


On 2/22/21 12:41 AM, Michal Hocko wrote:

>>
>>
>> Ah, that's true. The added check for soft_limit_excess is not needed.
>>
>> Do you think it is still a good idea to add patch 3 to
>> restrict the uncharge update in page batch of the same node and cgroup?
>
> I would rather drop it. The less the soft limit reclaim code is spread
> around the better.
>

Let's drop patch 3 then. I find patch 2 is the most critical one in this series.
Without that patch some cgroups exceeds the soft limit excess very badly.

Tim

\
 
 \ /
  Last update: 2021-02-22 18:48    [W:0.045 / U:1.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site