lkml.org 
[lkml]   [2021]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] arp: Remove the arp_hh_ops structure
From
Date
On 2/22/21 1:37 AM, Eric Dumazet wrote:
>
>
> On 2/22/21 4:15 AM, Yejune Deng wrote:
>> The arp_hh_ops structure is similar to the arp_generic_ops structure.
>> but the latter is more general,so remove the arp_hh_ops structure.
>>
>> Fix when took out the neigh->ops assignment:
>> 8.973653] #PF: supervisor read access in kernel mode
>> [ 8.975027] #PF: error_code(0x0000) - not-present page
>> [ 8.976310] PGD 0 P4D 0
>> [ 8.977036] Oops: 0000 [#1] SMP PTI
>> [ 8.977973] CPU: 1 PID: 210 Comm: sd-resolve Not tainted 5.11.0-rc7-02046-g4591591ab715 #1
>> [ 8.979998] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
>> [ 8.981996] RIP: 0010:neigh_probe (kbuild/src/consumer/net/core/neighbour.c:1009)
>>
>
> I have a hard time understanding this patch submission.
>
> This seems a mix of a net-next and net material ?

It is net-next at best.

>
>
>
>> Reported-by: kernel test robot <oliver.sang@intel.com>
>
> If this is a bug fix, we want a Fixes: tag
>
> This will really help us. Please don't let us guess what is going on.
>

This patch is a v2. v1 was clearly wrong and not tested; I responded as
such 12 hours before the robot test.

\
 
 \ /
  Last update: 2021-02-22 17:13    [W:0.060 / U:1.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site