Messages in this thread | | | Date | Mon, 22 Feb 2021 16:39:33 +0100 | From | Takashi Iwai <> | Subject | Re: [PATCH 15/20] ALSA: usb-audio: Manual replacement of the deprecated strlcpy() with return values |
| |
On Mon, 22 Feb 2021 16:12:26 +0100, Romain Perier wrote: > > The strlcpy() reads the entire source buffer first, it is dangerous if > the source buffer lenght is unbounded or possibility non NULL-terminated. > It can lead to linear read overflows, crashes, etc... > > As recommended in the deprecated interfaces [1], it should be replaced > by strscpy. > > This commit replaces all calls to strlcpy that handle the return values > by the corresponding strscpy calls with new handling of the return > values (as it is quite different between the two functions). > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy > > Signed-off-by: Romain Perier <romain.perier@gmail.com>
The strlcpy() usage in sound/* have been already converted on the latest Linus tree. So please drop this one.
thanks,
Takashi
| |