lkml.org 
[lkml]   [2021]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] kdb: Simplify kdb commands registration
On Mon, Feb 22, 2021 at 06:33:18PM +0530, Sumit Garg wrote:
> On Mon, 22 Feb 2021 at 17:35, Daniel Thompson
> <daniel.thompson@linaro.org> wrote:
> >
> > On Thu, Feb 18, 2021 at 05:39:58PM +0530, Sumit Garg wrote:
> > > Simplify kdb commands registration via using linked list instead of
> > > static array for commands storage.
> > >
> > > Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
> > > ---
> > >
> > > Changes in v4:
> > > - Fix kdb commands memory allocation issue prior to slab being available
> > > with an array of statically allocated commands. Now it works fine with
> > > kgdbwait.
> >
> > I'm not sure this is the right approach. It's still faking dynamic usage
> > when none of the callers at this stage of the boot actually are dynamic.
> >
>
> Okay, as an alternative I came across dbg_kmalloc()/dbg_kfree() as well but ...

Last time I traced these functions I concluded that this heap can be
removed if the symbol handling code is refactored a little. I'd be
*seriously* reluctant to add any new callers... which I assume from your
later comments you can live with ;-) .


Daniel.

\
 
 \ /
  Last update: 2021-02-22 15:19    [W:0.037 / U:12.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site