lkml.org 
[lkml]   [2021]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 06/50] ovl: perform vfs_getxattr() with mounter creds
    Date
    From: Miklos Szeredi <mszeredi@redhat.com>

    [ Upstream commit 554677b97257b0b69378bd74e521edb7e94769ff ]

    The vfs_getxattr() in ovl_xattr_set() is used to check whether an xattr
    exist on a lower layer file that is to be removed. If the xattr does not
    exist, then no need to copy up the file.

    This call of vfs_getxattr() wasn't wrapped in credential override, and this
    is probably okay. But for consitency wrap this instance as well.

    Reported-by: "Eric W. Biederman" <ebiederm@xmission.com>
    Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/overlayfs/inode.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c
    index 8b3c284ce92ea..08e60a6df77c3 100644
    --- a/fs/overlayfs/inode.c
    +++ b/fs/overlayfs/inode.c
    @@ -340,7 +340,9 @@ int ovl_xattr_set(struct dentry *dentry, struct inode *inode, const char *name,
    goto out;

    if (!value && !upperdentry) {
    + old_cred = ovl_override_creds(dentry->d_sb);
    err = vfs_getxattr(realdentry, name, NULL, 0);
    + revert_creds(old_cred);
    if (err < 0)
    goto out_drop_write;
    }
    --
    2.27.0


    \
     
     \ /
      Last update: 2021-02-22 13:42    [W:3.081 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site