lkml.org 
[lkml]   [2021]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] doc: use KCFLAGS instead of EXTRA_CFLAGS to pass flags from command line
From
Date
Reviewed-by: Alex Shi <alex.shi@linux.alibaba.com>


在 2021/2/21 下午11:25, Masahiro Yamada 写道:
> You should use KCFLAGS to pass additional compiler flags from the
> command line. Using EXTRA_CFLAGS is wrong.
>
> EXTRA_CFLAGS is supposed to specify flags applied only to the current
> Makefile (and now deprecated in favor of ccflags-y).
>
> It is still used in arch/mips/kvm/Makefile (and possibly in external
> modules too). Passing EXTRA_CFLAGS from the command line overwrites
> it and breaks the build.
>
> I also fixed drivers/gpu/drm/tilcdc/Makefile because commit 816175dd1fd7
> ("drivers/gpu/drm/tilcdc: Makefile, only -Werror when no -W* in
> EXTRA_CFLAGS") was based on the same misunderstanding.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> Documentation/process/4.Coding.rst | 2 +-
> Documentation/process/submit-checklist.rst | 2 +-
> Documentation/translations/it_IT/process/4.Coding.rst | 2 +-
> Documentation/translations/it_IT/process/submit-checklist.rst | 2 +-
> Documentation/translations/zh_CN/process/4.Coding.rst | 2 +-
> drivers/gpu/drm/tilcdc/Makefile | 2 +-
> 6 files changed, 6 insertions(+), 6 deletions(-)
>

\
 
 \ /
  Last update: 2021-02-22 06:07    [W:0.041 / U:4.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site