Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [GIT PULL] Please pull powerpc/linux.git powerpc-5.12-1 tag | Date | Tue, 23 Feb 2021 11:53:53 +1100 |
| |
"Oliver O'Halloran" <oohall@gmail.com> writes:
> On Tue, Feb 23, 2021 at 9:44 AM Linus Torvalds > <torvalds@linux-foundation.org> wrote: >> >> On Mon, Feb 22, 2021 at 4:06 AM Michael Ellerman <mpe@ellerman.id.au> wrote: >> > >> > Please pull powerpc updates for 5.12. >> >> Pulled. However: >> >> > mode change 100755 => 100644 tools/testing/selftests/powerpc/eeh/eeh-functions.sh >> > create mode 100755 tools/testing/selftests/powerpc/eeh/eeh-vf-aware.sh >> > create mode 100755 tools/testing/selftests/powerpc/eeh/eeh-vf-unaware.sh >> >> Somebody is being confused. >> >> Why create two new shell scripts with the proper executable bit, and >> then remove the executable bit from an existing one? >> >> That just seems very inconsistent. > > eeh-function.sh just provides some helper functions for the other > scripts and doesn't do anything when executed directly. I thought > making it non-executable made sense.
Yeah I think it does make sense. It just looks a bit odd in the diffstat like this. Maybe if we called it lib.sh it would be more obvious?
cheers
| |