lkml.org 
[lkml]   [2021]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] remoteproc: core: Remove casting to rproc_handle_resource_t
Hi,

On Sun, Feb 21, 2021 at 11:18 PM Jindong Yue <jindong.yue@nxp.com> wrote:
>
> There are four different callback functions that are used for the
> rproc_handle_resource_t callback that all have different second
> parameter types.
>
> rproc_handle_vdev -> struct fw_rsc_vdev
> rproc_handle_trace -> struct fw_rsc_trace
> rproc_handle_devmem -> struct fw_rsc_devmem
> rproc_handle_carveout -> struct fw_rsc_carveout
>
> These callbacks are cast to rproc_handle_resource_t so that there is no
> error about incompatible pointer types. Unfortunately, this is a control
> flow integrity violation, which verifies that the callback function's
> types match the prototypes exactly before jumping.

Thank you for sending the patch! It might be worth noting that Clang's
Control-Flow Integrity checking is currently used only in Android
kernels, so while the type mismatches are real and should be fixed,
they don't result in runtime errors without this feature.

> To fix this, change the second parameter of all functions to void * and
> use a local variable with the correct type so that everything works
> properly. With this, we can remove casting to rproc_handle_resource_t
> for these functions.
>
> Signed-off-by: Jindong Yue <jindong.yue@nxp.com>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>

This looks correct to me. Please feel free to add:

Reviewed-by: Sami Tolvanen <samitolvanen@google.com>

Sami

\
 
 \ /
  Last update: 2021-02-22 23:51    [W:0.036 / U:8.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site