lkml.org 
[lkml]   [2021]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [GIT PULL] Devicetree updates for v5.12
On Mon, Feb 22, 2021 at 9:35 AM Rob Herring <robh@kernel.org> wrote:
>
> Please pull DT updates for v5.12.

Ugh.

This causes "git status" to be unhappy, because there's a new
generated file (scripts/dtc/fdtoverlay) without a gitignore entry.

This was added by commit 79edff12060f ("scripts/dtc: Update to
upstream version v1.6.0-51-g183df9e9c2b9"), and then enabled in commit
0da6bcd9fcc0 ("scripts: dtc: Build fdtoverlay tool"). But it was
already referenced before it was even added (by commit b775f49fbc8b:
"scripts: dtc: Fetch fdtoverlay.c from external DTC project", which
didn't actually fetch that thing at all!)

And that commit 79edff12060f is all kinds of strange anyway, in that
it *claims* to have taken some (other) gitignore updates from the
upstream dtc code, but it very clearly does no such thing.

So I have to say - that whole thing was done very very badly. Actively
incorrect commit messages, complete mess about when things were added,
and the end result isn't great.

Sadly, I only noticed after I had pulled and pushed out.

Please fix. Not just the current mess with the incomplete .gitignore
file, but the whole clearly broken workflow.

Linus

\
 
 \ /
  Last update: 2021-02-22 19:55    [W:0.036 / U:17.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site