Messages in this thread | | | Subject | Re: [PATCH net-next] net: dsa: Fix dependencies with HSR | From | Florian Fainelli <> | Date | Fri, 19 Feb 2021 21:14:36 -0800 |
| |
On 2/19/2021 9:12 PM, Florian Fainelli wrote: > The core DSA framework uses hsr_is_master() which would not resolve to a > valid symbol if HSR is built-into the kernel and DSA is a module. > > Fixes: 18596f504a3e ("net: dsa: add support for offloading HSR") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > David, Jakub, > > This showed up in linux-next which means it will show up in Linus' tree > soon as well when your pull request gets sent out.
I had initially considered making is_hsr_master() a static inline that would compare dev->dev.type->name with "hsr" since the HSR master would set a custom dev_type, however the xrs700x driver would still fail to link because it calls hsr_get_version() and for that one there is no easy solution. -- Florian
| |