Messages in this thread | | | Subject | Re: [PATCH] virt: acrn: Use vfs_poll() instead of f_op->poll() | From | "Liu, Shuo A" <> | Date | Sun, 21 Feb 2021 09:50:42 +0800 |
| |
On 2/20/2021 22:53, Yejune Deng wrote: > Use vfs_poll() is a more advanced function in acrn_irqfd_assign(). > as the same time, modify the definition of events. > > Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
Thanks for the update. Reviewed-by: Shuo Liu <shuo.a.liu@intel.com>
Hi Greg, Need i do more work on this patch? Or you will review and apply on your tree directly?
Thanks shuo
> --- > drivers/virt/acrn/irqfd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/virt/acrn/irqfd.c b/drivers/virt/acrn/irqfd.c > index a8766d528e29..98d6e9b18f9e 100644 > --- a/drivers/virt/acrn/irqfd.c > +++ b/drivers/virt/acrn/irqfd.c > @@ -112,7 +112,7 @@ static int acrn_irqfd_assign(struct acrn_vm *vm, struct acrn_irqfd *args) > { > struct eventfd_ctx *eventfd = NULL; > struct hsm_irqfd *irqfd, *tmp; > - unsigned int events; > + __poll_t events; > struct fd f; > int ret = 0; > > @@ -158,7 +158,7 @@ static int acrn_irqfd_assign(struct acrn_vm *vm, struct acrn_irqfd *args) > mutex_unlock(&vm->irqfds_lock); > > /* Check the pending event in this stage */ > - events = f.file->f_op->poll(f.file, &irqfd->pt); > + events = vfs_poll(f.file, &irqfd->pt); > > if (events & POLLIN) > acrn_irqfd_inject(irqfd); >
| |