Messages in this thread | | | Date | Tue, 2 Feb 2021 17:20:45 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] ceph: fix an oops in error handling in ceph_netfs_issue_op |
| |
On Tue, Feb 02, 2021 at 08:10:41AM -0500, Jeff Layton wrote: > Dan reported a potential oops in the cleanup if ceph_osdc_new_request > returns an error. Eliminate the unneeded initialization of "req" and > then just set it to NULL in the case where it holds an ERR_PTR. > > Also, drop the unneeded NULL check before calling > ceph_osdc_put_request. > > Fixes: 1cf7fdf52d5a ("ceph: convert readpage to fscache read helper") > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Suggested-by: Ilya Dryomov <idryomov@gmail.com> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
Looks good.
Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
regards, dan carpenter
| |