lkml.org 
[lkml]   [2021]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 064/142] drm/i915/selftest: Fix potential memory leak
    Date
    From: Pan Bian <bianpan2016@163.com>

    commit 3d480fe1befa0ef434f5c25199e7d45c26870555 upstream.

    Object out is not released on path that no VMA instance found. The root
    cause is jumping to an unexpected label on the error path.

    Fixes: a47e788c2310 ("drm/i915/selftests: Exercise CS TLB invalidation")
    Signed-off-by: Pan Bian <bianpan2016@163.com>
    Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Link: https://patchwork.freedesktop.org/patch/msgid/20210122015640.16002-1-bianpan2016@163.com
    (cherry picked from commit 2b015017d5cb01477a79ca184ac25c247d664568)
    Signed-off-by: Jani Nikula <jani.nikula@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
    +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
    @@ -1880,7 +1880,7 @@ static int igt_cs_tlb(void *arg)
    vma = i915_vma_instance(out, vm, NULL);
    if (IS_ERR(vma)) {
    err = PTR_ERR(vma);
    - goto out_put_batch;
    + goto out_put_out;
    }

    err = i915_vma_pin(vma, 0, 0,

    \
     
     \ /
      Last update: 2021-02-02 14:56    [W:4.023 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site