Messages in this thread Patch in this message | | | Date | Tue, 2 Feb 2021 12:51:26 +0100 | From | Greg KH <> | Subject | Re: [PATCH v2 3/9] scsi: ufshpb: Add region's reads counter |
| |
On Tue, Feb 02, 2021 at 11:23:17AM +0000, Avri Altman wrote: > > > > > > On Tue, Feb 02, 2021 at 10:30:01AM +0200, Avri Altman wrote: > > > @@ -175,6 +179,8 @@ struct ufshpb_lu { > > > > > > /* for selecting victim */ > > > struct victim_select_info lru_info; > > > + struct work_struct ufshpb_normalization_work; > > > + unsigned long work_data_bits; > > > > You only have 1 "bit" being used here, so perhaps just a u8? Please > > don't use things like "unsigned long" for types, this isn't Windows :) > I am using it for atomic bit operations.
Ah, and that requires "unsigned long"? Ok, nevermind :)
| |