Messages in this thread | | | Date | Tue, 2 Feb 2021 10:45:25 +0100 | From | Petr Mladek <> | Subject | Re: [PATCH printk-rework 12/12] printk: kmsg_dump: remove _nolock() variants |
| |
On Tue 2021-01-26 22:21:51, John Ogness wrote: > kmsg_dump_rewind() and kmsg_dump_get_line() are lockless, so there is > no need for _nolock() variants. Remove these functions and switch all > callers of the _nolock() variants. > > The functions without _nolock() were chosen because they are already > exported to kernel modules. > > Signed-off-by: John Ogness <john.ogness@linutronix.de>
Makes perfect sense. Just please move the printk_safe enter/exit calls from the previous patch into this one. Of course, only if you still want to keep them for now.
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards, Petr
| |