lkml.org 
[lkml]   [2021]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH net-next] net: fix up truesize of cloned skb in skb_prepare_for_shift()
On Mon, Feb 1, 2021 at 9:58 AM Eric Dumazet <edumazet@google.com> wrote:
>
> On Mon, Feb 1, 2021 at 6:34 PM Marco Elver <elver@google.com> wrote:
> >
> > On Mon, 1 Feb 2021 at 17:50, Christoph Paasch
>
> > > just a few days ago we found out that this also fixes a syzkaller
> > > issue on MPTCP (https://github.com/multipath-tcp/mptcp_net-next/issues/136).
> > > I confirmed that this patch fixes the issue for us as well:
> > >
> > > Tested-by: Christoph Paasch <christoph.paasch@gmail.com>
> >
> > That's interesting, because according to your config you did not have
> > KFENCE enabled. Although it's hard to say what exactly caused the
> > truesize mismatch in your case, because it clearly can't be KFENCE
> > that caused ksize(kmalloc(S))!=ksize(kmalloc(S)) for you.
>
> Indeed, this seems strange. This might be a different issue.
>
> Maybe S != S ;)

Seems like letting syzkaller run for a few more days made it
eventually find the WARN again. As if Marco's change makes it harder
for us to trigger the issue.

Anyways, you can remove my "Tested-by" ;-)


Christoph

\
 
 \ /
  Last update: 2021-02-02 18:03    [W:0.065 / U:0.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site