Messages in this thread | | | Date | Fri, 19 Feb 2021 16:56:44 +0100 | From | Petr Mladek <> | Subject | Re: [PATCH printk-rework 09/14] printk: introduce a kmsg_dump iterator |
| |
On Thu 2021-02-18 09:18:12, John Ogness wrote: > Rather than store the iterator information into the registered
s/store/storing/ ?
> kmsg_dump structure, create a separate iterator structure. The > kmsg_dump_iter structure can reside on the stack of the caller, > thus allowing lockless use of the kmsg_dump functions. > > This is in preparation for removal of @logbuf_lock. > > diff --git a/include/linux/kmsg_dump.h b/include/linux/kmsg_dump.h > index 4095a34db0fa..2fdb10ab1799 100644 > --- a/include/linux/kmsg_dump.h > +++ b/include/linux/kmsg_dump.h > @@ -29,6 +29,18 @@ enum kmsg_dump_reason { > KMSG_DUMP_MAX > }; > > +/** > + * struct kmsg_dumper_iter - iterator for kernel crash message dumper > + * @active: Flag that specifies if this is currently dumping > + * @cur_seq: Points to the oldest message to dump (private) > + * @next_seq: Points after the newest message to dump (private)
"(private)" might be removed.
Anyway, the issues are only cosmetic:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards, Petr
| |