lkml.org 
[lkml]   [2021]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectR: [PATCH v1] watchdog: wdat: add param. to start wdog on module insertion
Date
Hi Mika,

> > const struct wdat_instruction *instr, u32 *value)
> > {
> > @@ -437,6 +443,8 @@ static int wdat_wdt_probe(struct platform_device
> *pdev)
> > }
> >
> > wdat_wdt_boot_status(wdat);
> > + if (start_enabled)
> > + wdat_wdt_start(&wdat->wdd);
>
> No objections to this if it is really needed. However, I think it is
> better start the watchdog after devm_watchdog_register_device() has been
> called so we have everything initialized.

Yes, it is needed. We need this feature to enable the watchdog
as soon as possible and this is essential for unmanned applications,
such as routers, water pumping stations, climate data collections,
etc.

Right, ok for the correct positioning of the wdat_wdt_start function
at the end of the watchdog device initialization. Thanks!

>
> > wdat_wdt_set_running(wdat);
> >
> > ret = wdat_wdt_enable_reboot(wdat);
> > --
> > 2.25.1

Regards,
Flavio

\
 
 \ /
  Last update: 2021-02-19 15:03    [W:0.073 / U:26.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site