lkml.org 
[lkml]   [2021]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: rtl8723bs: make if-statement checkpatch.pl conform
On Thu, Feb 18, 2021 at 07:50:27PM +0000, Kurt Manucredo wrote:
> Signed-off-by: Kurt Manucredo <fuzzybritches@protonmail.com>
> ---
>
> The preferred coding style is:
> if (!StaAddr)
> return;

Above the Signed-off-by line. Also indenting is wrong. And it's hard
to understand what you're saying.

>
> thank you mr. dan carpenter

You're welcome. (These sorts of comments do go below the --- cut off
line so that's fine.)

regards,
dan carpenter

\
 
 \ /
  Last update: 2021-02-19 08:03    [W:0.038 / U:1.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site