lkml.org 
[lkml]   [2021]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2] vfs: prevent copy_file_range to copy across devices
    On Thu, Feb 18, 2021 at 9:42 AM Christoph Hellwig <hch@infradead.org> wrote:
    >
    > Looks good:
    >
    > Reviewed-by: Christoph Hellwig <hch@lst.de>
    >
    > This whole idea of cross-device copie has always been a horrible idea,
    > and I've been arguing against it since the patches were posted.

    Ok. I'm good with this v2 as well, but need to add the fallback to
    do_splice_direct()
    in nfsd_copy_file_range(), because this patch breaks it.

    And the commit message of v3 is better in describing the reported issue.

    Thanks,
    Amir.

    \
     
     \ /
      Last update: 2021-02-18 11:39    [W:2.313 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site