lkml.org 
[lkml]   [2021]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH][next] net: hns3: Fix uninitialized return from function
From
Date

在 2021/2/10 23:26, Colin King 写道:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently function hns3_reset_notify_uninit_enet is returning
> the contents of the uninitialized variable ret. Fix this by
> removing ret (since it is no longer used) and replace it with
> a return of the literal value 0.


you can not remove "ret"  this way.

try to change  "int hns3_uninit_all_ring"  to "void
hns3_uninit_all_ring" and fix related code is better.


>
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: 64749c9c38a9 ("net: hns3: remove redundant return value of hns3_uninit_all_ring()")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> index 9565b7999426..bf4302a5cf95 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> @@ -4640,7 +4640,6 @@ static int hns3_reset_notify_uninit_enet(struct hnae3_handle *handle)
> {
> struct net_device *netdev = handle->kinfo.netdev;
> struct hns3_nic_priv *priv = netdev_priv(netdev);
> - int ret;
>
> if (!test_and_clear_bit(HNS3_NIC_STATE_INITED, &priv->state)) {
> netdev_warn(netdev, "already uninitialized\n");
> @@ -4662,7 +4661,7 @@ static int hns3_reset_notify_uninit_enet(struct hnae3_handle *handle)
>
> hns3_put_ring_config(priv);
>
> - return ret;
> + return 0;
> }
>
> static int hns3_reset_notify(struct hnae3_handle *handle,

\
 
 \ /
  Last update: 2021-02-18 03:16    [W:0.056 / U:1.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site