Messages in this thread | | | From | Oded Gabbay <> | Date | Tue, 16 Feb 2021 21:33:27 +0200 | Subject | Re: [PATCH] drivers: habanalabs: remove unused dentry pointer for debugfs files |
| |
On Tue, Feb 16, 2021 at 5:08 PM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > The dentry for the created debugfs file was being saved, but never used > anywhere. As the pointer isn't needed for anything, and the debugfs > files are being properly removed by removing the parent directory, > remove the saved pointer as well, saving a tiny bit of memory and logic. > > Cc: Oded Gabbay <ogabbay@kernel.org> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Tomer Tayar <ttayar@habana.ai> > Cc: Moti Haimovski <mhaimovski@habana.ai> > Cc: Omer Shpigelman <oshpigelman@habana.ai> > Cc: Ofir Bitton <obitton@habana.ai> > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/misc/habanalabs/common/debugfs.c | 5 +---- > drivers/misc/habanalabs/common/habanalabs.h | 2 -- > 2 files changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/misc/habanalabs/common/debugfs.c b/drivers/misc/habanalabs/common/debugfs.c > index cef716643979..770b0131397d 100644 > --- a/drivers/misc/habanalabs/common/debugfs.c > +++ b/drivers/misc/habanalabs/common/debugfs.c > @@ -965,7 +965,6 @@ void hl_debugfs_add_device(struct hl_device *hdev) > struct hl_dbg_device_entry *dev_entry = &hdev->hl_debugfs; > int count = ARRAY_SIZE(hl_debugfs_list); > struct hl_debugfs_entry *entry; > - struct dentry *ent; > int i; > > dev_entry->hdev = hdev; > @@ -1072,13 +1071,11 @@ void hl_debugfs_add_device(struct hl_device *hdev) > &hl_stop_on_err_fops); > > for (i = 0, entry = dev_entry->entry_arr ; i < count ; i++, entry++) { > - > - ent = debugfs_create_file(hl_debugfs_list[i].name, > + debugfs_create_file(hl_debugfs_list[i].name, > 0444, > dev_entry->root, > entry, > &hl_debugfs_fops); > - entry->dent = ent; > entry->info_ent = &hl_debugfs_list[i]; > entry->dev_entry = dev_entry; > } > diff --git a/drivers/misc/habanalabs/common/habanalabs.h b/drivers/misc/habanalabs/common/habanalabs.h > index 60e16dc4bcac..48937e9eed83 100644 > --- a/drivers/misc/habanalabs/common/habanalabs.h > +++ b/drivers/misc/habanalabs/common/habanalabs.h > @@ -1393,12 +1393,10 @@ struct hl_info_list { > > /** > * struct hl_debugfs_entry - debugfs dentry wrapper. > - * @dent: base debugfs entry structure. > * @info_ent: dentry realted ops. > * @dev_entry: ASIC specific debugfs manager. > */ > struct hl_debugfs_entry { > - struct dentry *dent; > const struct hl_info_list *info_ent; > struct hl_dbg_device_entry *dev_entry; > }; > -- > 2.30.1 >
This patch is: Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Thanks, Oded
| |