Messages in this thread | | | Subject | Re: [PATCH v4] tpm: fix reference counting for struct tpm_chip | From | Lino Sanfilippo <> | Date | Tue, 16 Feb 2021 20:08:10 +0100 |
| |
Hi,
On 16.02.21 at 17:11, Jarkko Sakkinen wrote: > On Tue, Feb 16, 2021 at 06:09:50PM +0200, Jarkko Sakkinen wrote: >> On Tue, Feb 16, 2021 at 06:04:42PM +0200, Jarkko Sakkinen wrote: >>> On Tue, Feb 16, 2021 at 08:53:42AM -0400, Jason Gunthorpe wrote: >>>> On Tue, Feb 16, 2021 at 01:31:00AM +0100, Lino Sanfilippo wrote: >>>>> >>>>> +static int tpm_add_tpm2_char_device(struct tpm_chip *chip) >>> >>> BTW, this naming is crap. >>> >>> - 2x tpm >>> - char is useless >>> >>> -> tpm2_add_device >> >> Actually, tpm2s_add_device() add put it to tpm2-space.c. > > No, tpms_add_device() :-) > > (sorry) > > /Jarkko >
I strongly assume you mean tmp2_add_device() :) I will move and rename the function accordingly.
Thanks, Lino
| |