Messages in this thread | | | Date | Mon, 15 Feb 2021 22:18:41 +0100 | From | Krzysztof Wilczyński <> | Subject | Re: [PATCH v1 0/4] Introduce pcim_alloc_irq_vectors() |
| |
Hi Dejin,
Thank you for working on this series!
Do you have a link to the conversation that prompted addition of this new function? If so, then it would be nice to include a reference to it here (as a link to http://lore.kernel.org/) in the cover letter for reference, if possible, of course.
Generally, it would also be nice to expand on things a little bit and explain why do you want to add this new function, and what problems does it solve.
[...] > Introduce pcim_alloc_irq_vectors(), a explicit device-managed version of > pci_alloc_irq_vectors(). and use the correct name of device-managed > function to alloc irq vectors in i2c drivers.
Did you want to use a comma, instead of a period, in the sentence above? You could also probably drop the word "explicit".
Krzysztof
| |