Messages in this thread | | | Date | Mon, 15 Feb 2021 12:41:45 -0500 | From | Alan Stern <> | Subject | Re: usb: dwc3: gadget: Change runtime pm function for DWC3 runtime suspend |
| |
On Mon, Feb 15, 2021 at 11:38:58AM +0900, Daehwan Jung wrote: > It seems pm_runtime_put calls runtime_idle callback not runtime_suspend callback.
How is this fact related to your patch?
> It's better to use pm_runtime_put_sync_suspend to allow DWC3 runtime suspend.
Why do you think it is better? The advantage of pm_runtime_put is that it allows the suspend to occur at a later time in a workqueue thread, so the caller doesn't have to wait for the device to go into suspend.
Alan Stern
> Signed-off-by: Daehwan Jung <dh10.jung@samsung.com> > --- > drivers/usb/dwc3/gadget.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > index aebcf8e..4a4b93b 100644 > --- a/drivers/usb/dwc3/gadget.c > +++ b/drivers/usb/dwc3/gadget.c > @@ -2229,7 +2229,7 @@ static int dwc3_gadget_pullup(struct usb_gadget *g, int is_on) > */ > ret = pm_runtime_get_sync(dwc->dev); > if (!ret || ret < 0) { > - pm_runtime_put(dwc->dev); > + pm_runtime_put_sync_suspend(dwc->dev); > return 0; > } > > -- > 2.7.4 >
| |