lkml.org 
[lkml]   [2021]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 16/60] drm/amd/display: Fix dc_sink kref count in emulated_link_detect
    Date
    From: Victor Lu <victorchengchi.lu@amd.com>

    [ Upstream commit 3ddc818d9bb877c64f5c649beab97af86c403702 ]

    [why]
    prev_sink is not used anywhere else in the function and the reference to
    it from dc_link is replaced with a new dc_sink.

    [how]
    Change dc_sink_retain(prev_sink) to dc_sink_release(prev_sink).

    Signed-off-by: Victor Lu <victorchengchi.lu@amd.com>
    Reviewed-by: Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>
    Acked-by: Anson Jacob <Anson.Jacob@amd.com>
    Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
    index de06ee7d2ad46..3671b3e8f69d8 100644
    --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
    +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
    @@ -1093,8 +1093,8 @@ static void emulated_link_detect(struct dc_link *link)
    link->type = dc_connection_none;
    prev_sink = link->local_sink;

    - if (prev_sink != NULL)
    - dc_sink_retain(prev_sink);
    + if (prev_sink)
    + dc_sink_release(prev_sink);

    switch (link->connector_signal) {
    case SIGNAL_TYPE_HDMI_TYPE_A: {
    --
    2.27.0


    \
     
     \ /
      Last update: 2021-02-15 17:00    [W:2.983 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site