Messages in this thread | | | From | Andy Shevchenko <> | Date | Mon, 15 Feb 2021 17:13:44 +0200 | Subject | Re: [net-next PATCH v5 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver |
| |
On Mon, Feb 15, 2021 at 2:33 PM Calvin Johnson <calvin.johnson@oss.nxp.com> wrote: > On Mon, Feb 08, 2021 at 04:28:31PM +0000, Russell King - ARM Linux admin wrote:
...
> I think of_phy_is_fixed_link() needs to be fixed. I'll add below fix. > > --- a/drivers/net/mdio/of_mdio.c > +++ b/drivers/net/mdio/of_mdio.c > @@ -439,6 +439,9 @@ bool of_phy_is_fixed_link(struct device_node *np) > int len, err; > const char *managed; > > + if (!np) > + return false;
AFAICS this doesn't add anything: all of the of_* APIs should handle OF nodes being NULL below.
> /* New binding */ > dn = of_get_child_by_name(np, "fixed-link"); > if (dn) {
-- With Best Regards, Andy Shevchenko
| |