lkml.org 
[lkml]   [2021]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH V10 05/10] remoteproc: imx_rproc: correct err message
    Date
    From: Peng Fan <peng.fan@nxp.com>

    It is using devm_ioremap, so not devm_ioremap_resource. Correct
    the error message and print out sa/size.

    Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
    Signed-off-by: Peng Fan <peng.fan@nxp.com>
    ---
    drivers/remoteproc/imx_rproc.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
    index 6603e00bb6f4..2a093cea4997 100644
    --- a/drivers/remoteproc/imx_rproc.c
    +++ b/drivers/remoteproc/imx_rproc.c
    @@ -268,7 +268,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
    priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev,
    att->sa, att->size);
    if (!priv->mem[b].cpu_addr) {
    - dev_err(dev, "devm_ioremap_resource failed\n");
    + dev_err(dev, "failed to remap %#x bytes from %#x\n", att->size, att->sa);
    return -ENOMEM;
    }
    priv->mem[b].sys_addr = att->sa;
    @@ -298,7 +298,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,

    priv->mem[b].cpu_addr = devm_ioremap_resource(&pdev->dev, &res);
    if (IS_ERR(priv->mem[b].cpu_addr)) {
    - dev_err(dev, "devm_ioremap_resource failed\n");
    + dev_err(dev, "failed to remap %pr\n", &res);
    err = PTR_ERR(priv->mem[b].cpu_addr);
    return err;
    }
    --
    2.30.0
    \
     
     \ /
      Last update: 2021-02-15 13:53    [W:5.410 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site