lkml.org 
[lkml]   [2021]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH net] net: ipa: initialize all resources
    Date
    We configure the minimum and maximum number of various types of IPA
    resources in ipa_resource_config(). It iterates over resource types
    in the configuration data and assigns resource limits to each
    resource group for each type.

    Unfortunately, we are repeatedly initializing the resource data for
    the first type, rather than initializing each of the types whose
    limits are specified.

    Fix this bug.

    Fixes: 4a0d7579d466e ("net: ipa: avoid going past end of resource group array")
    Signed-off-by: Alex Elder <elder@linaro.org>
    ---
    drivers/net/ipa/ipa_main.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c
    index 84bb8ae927252..eb1c8396bcdd9 100644
    --- a/drivers/net/ipa/ipa_main.c
    +++ b/drivers/net/ipa/ipa_main.c
    @@ -581,10 +581,10 @@ ipa_resource_config(struct ipa *ipa, const struct ipa_resource_data *data)
    return -EINVAL;

    for (i = 0; i < data->resource_src_count; i++)
    - ipa_resource_config_src(ipa, data->resource_src);
    + ipa_resource_config_src(ipa, &data->resource_src[i]);

    for (i = 0; i < data->resource_dst_count; i++)
    - ipa_resource_config_dst(ipa, data->resource_dst);
    + ipa_resource_config_dst(ipa, &data->resource_dst[i]);

    return 0;
    }
    --
    2.20.1
    \
     
     \ /
      Last update: 2021-02-15 22:56    [W:3.699 / U:0.916 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site